Changeset b2e077a for server/lib/gutenbach/ipp/attributegroup.py

Timestamp:

Dec 18, 2011, 11:18:16 PM (12 years ago)

Author:

Jessica B. Hamrick <jhamrick@…>

Branches:

no-cups

Children:

9eeab06

Parents:

d04a689

git-author:

Jessica B. Hamrick <jhamrick@…> (12/18/11 23:18:16)

git-committer:

Jessica B. Hamrick <jhamrick@…> (12/18/11 23:18:16)

Message:

Refactor code to handle the operations a little bit more logically

File:

• server/lib/gutenbach/ipp/attributegroup.py (modified) (4 diffs)

server/lib/gutenbach/ipp/attributegroup.py

@@ -16 +16 @@
     """
 
-    def __init__(self, attribute_group_tag=None, attributes=[]):
+    def __init__(self, tag=None, attributes=[]):
         """Initialize an AttributeGroup.  An AttributeGroup can be
         initialized in three ways:
 
             AttributeGroup()
-            AttributeGroup(attribute_group_tag)
-            AttributeGroup(attribute_group_tag, attributes)
+            AttributeGroup(tag)
+            AttributeGroup(tag, attributes)
 
         Arguments:
 
-            attribute_group_tag -- a signed char, holds the tag of the
-                                   attribute group
+            tag -- a signed char, holds the tag of the
+                   attribute group
 
             attributes -- a list of attributes
@@ -33 +33 @@
         """
 
-        if attribute_group_tag is not None:
-            assert isinstance(attribute_group_tag, int), \
-                   "attribute_group_tag must be a character!"
-            
+        if tag is not None:
+            assert isinstance(tag, int), \
+                   "tag must be a character!"
 
-        self.attribute_group_tag = attribute_group_tag
+        self.tag = tag
         self.attributes = []
         self.extend(attributes)
@@ -97 +96 @@
         """
 
-        # conver the attribute_group_tag to binary
-        tag = struct.pack('>b', self.attribute_group_tag)
+        # convert the tag to binary
+        tag = struct.pack('>b', self.tag)
 
         # convert each of the attributes to binary
@@ -107 +106 @@
 
     def __repr__(self):
-        return '<IPPAttributeGroup (%r, %r)>' % (self.attribute_group_tag, self.attributes)
+        return '<IPPAttributeGroup (%r, %r)>' % (self.tag, self.attributes)