Changeset 59a1d4a for server/lib/gutenbach/ipp/operations.py

Timestamp:

Dec 20, 2011, 3:20:13 PM (12 years ago)

Author:

Jessica B. Hamrick <jhamrick@…>

Branches:

no-cups

Children:

aef164a

Parents:

ef8df33

git-author:

Jessica B. Hamrick <jhamrick@…> (12/20/11 15:20:13)

git-committer:

Jessica B. Hamrick <jhamrick@…> (12/20/11 15:20:13)

Message:

A litte bit of documentation

File:

• server/lib/gutenbach/ipp/operations.py (modified) (8 diffs)

server/lib/gutenbach/ipp/operations.py

@@ -21 +21 @@
         raise err.VersionNotSupported(str(request.version))
 
-    # check operation id
+    # XXX: check operation id
     if False:
         raise err.OperationNotSupported(str(request.operation_id))
@@ -31 +31 @@
             "Attribute group does not have OPERATION tag: 0x%x" % op_attrs.tag)
 
+    # XXX: if these aren't valid, then you HAVE to return something
+    # special.  See RFC 2911 3.1.6.1
     # # check compression
     # if False:
@@ -474 +476 @@
     return out
 
-
 def make_get_printer_attributes_response(attrs, request):
     """3.2.5.2 Get-Printer-Attributes Response
@@ -525 +526 @@
     return response
 
+### CUPS-GET-DEFAULT
 
 def verify_cups_get_default_request(request):
@@ -576 +578 @@
     make_printer_attributes(attrs, request, response)
     return response
+
+### CUPS-GET-PRINTERS
 
 def verify_cups_get_printers_request(request):
@@ -619 +623 @@
     """
 
+    # XXX: actually do something here
     return {}
 
@@ -648 +653 @@
         make_printer_attributes(printer, request, response)
     return response
+
+### CUPS-GET-CLASSES
 
 def verify_cups_get_classes_request(request):
@@ -692 +699 @@
     """
 
+    # XXX: actually do something here
     return {}